So I think I have found a bug or issue with ArcGIS Pro 1.2. I was trying to create a layer package using a layer which contains a definition query. The Create Layer Package tool generates a General Function Error every time and so does the create Map Package tool. All the required metadata is entered for the layer and the analysis tool does not indicate a problem. If I export the layer with the definition query to a new feature class/layer that contains only the features that displayed using the definition query (basically removing the need for the definition query but now having two feature classes), the Layer Package is successful.
So is this a bug, the way it is suppose to work or me doing something wrong?